pull-request: mhwd-kernel: show exact kernel version - additional general cleanups #72

Open
opened 2022-10-28 07:27:21 +00:00 by gothicVI · 5 comments
gothicVI commented 2022-10-28 07:27:21 +00:00 (Migrated from gitlab2.manjaro.org)

mhwd-kernel - in contrast to the GUI tool manjaro settings - does not display if a kernel is a release candidate or not.
This holds true for installed and available kernels.

This PR remedies that by showing the actual package version next to the displayed name.

Previously:

$ mhwd-kernel -li
Currently running: 6.0.8-1-MANJARO (linux60)
The following kernels are installed in your system:
   * linux515
   * linux60
$ mhwd-kernel -l
available kernels:
   * linux419
   * linux510
   * linux515
   * linux519
   * linux54
   * linux60
   * linux61
   * linux515-rt
   * linux519-rt

With this PR:

$ mhwd-kernel -li
Currently running: 6.0.8-1-MANJARO (linux60 [6.0.8-1])
The following kernels are installed in your system:
   * linux515 [5.15.78-1]
   * linux60 [6.0.8-1]
$ mhwd-kernel -l
available kernels:
   * linux419 [4.19.265-1]
   * linux510 [5.10.154-1]
   * linux515 [5.15.78-1]
   * linux519 [5.19.17-2]
   * linux54 [5.4.224-1]
   * linux60 [6.0.8-1]
   * linux61 [6.1.0rc4-1]
   * linux515-rt [5.15.76_rt53-2]
   * linux60-rt [6.0.5_rt14-2]

Additionally, some shellcheck compliance is introduced and the code is cleaned up a bit by removing trailing white spaces.

`mhwd-kernel` - in contrast to the GUI tool manjaro settings - does not display if a kernel is a release candidate or not. This holds true for installed and available kernels. [This PR](https://github.com/gothicVI/gitlab-manjaro-org-applications-mhwd) remedies that by showing the actual package version next to the displayed name. Previously: ```bash $ mhwd-kernel -li Currently running: 6.0.8-1-MANJARO (linux60) The following kernels are installed in your system: * linux515 * linux60 $ mhwd-kernel -l available kernels: * linux419 * linux510 * linux515 * linux519 * linux54 * linux60 * linux61 * linux515-rt * linux519-rt ``` With this PR: ```bash $ mhwd-kernel -li Currently running: 6.0.8-1-MANJARO (linux60 [6.0.8-1]) The following kernels are installed in your system: * linux515 [5.15.78-1] * linux60 [6.0.8-1] $ mhwd-kernel -l available kernels: * linux419 [4.19.265-1] * linux510 [5.10.154-1] * linux515 [5.15.78-1] * linux519 [5.19.17-2] * linux54 [5.4.224-1] * linux60 [6.0.8-1] * linux61 [6.1.0rc4-1] * linux515-rt [5.15.76_rt53-2] * linux60-rt [6.0.5_rt14-2] ``` Additionally, some [shellcheck](https://www.shellcheck.net/) compliance is introduced and the code is cleaned up a bit by removing trailing white spaces.
papajoke commented 2022-11-13 12:23:38 +00:00 (Migrated from gitlab2.manjaro.org)

not clear for me -li

 mhwd-kernel -li
Currently running: 5.19.16-4-MANJARO (linux519 [5.19.17-1])
The following kernels are installed in your system:
   * linux519 [5.19.17-1]
mhwd-kernel -l
available kernels:
   * linux519 [5.19.17-1]

following kernels are installed in your system but i don't view version installed ...


in title show if kernel is rc
why not only display RC or not ? version is for me not necessarily/too much

not clear for me `-li` ``` mhwd-kernel -li Currently running: 5.19.16-4-MANJARO (linux519 [5.19.17-1]) The following kernels are installed in your system: * linux519 [5.19.17-1] mhwd-kernel -l available kernels: * linux519 [5.19.17-1] ``` `following kernels are installed in your system` but i don't view version installed ... -------- in title `show if kernel is rc ` why not only display `RC` or not ? version is for me not necessarily/too much
gothicVI commented 2022-11-14 14:12:58 +00:00 (Migrated from gitlab2.manjaro.org)

changed title from pull-request: mhwd-kernel: show {-if-} kernel {-is rc and display more informat-}ion - additional general cleanups to pull-request: mhwd-kernel: show {+exact+} kernel {+vers+}ion - additional general cleanups

changed title from **pull-request: mhwd-kernel: show {-if-} kernel {-is rc and display more informat-}ion - additional general cleanups** to **pull-request: mhwd-kernel: show {+exact+} kernel {+vers+}ion - additional general cleanups**
gothicVI commented 2022-11-14 14:12:58 +00:00 (Migrated from gitlab2.manjaro.org)

changed the description

changed the description
gothicVI commented 2022-11-14 14:15:57 +00:00 (Migrated from gitlab2.manjaro.org)

Hi, @papajoke thanks for taking a look.
I've updated the example which hopefully remedies the confusion.
If not please elaborate.

I'm not sure if only displaying RC is possible due to the way the strings are built initially.
Do you have an idea?

Hi, @papajoke thanks for taking a look. I've updated the example which hopefully remedies the confusion. If not please elaborate. I'm not sure if only displaying RC is possible due to the way the strings are built initially. Do you have an idea?
yochananmarqos1 commented 2024-05-05 19:32:09 +00:00 (Migrated from gitlab2.manjaro.org)

assigned to @philm

assigned to @philm
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
applications/mhwd#72
No description provided.