manjaro version of `mkarchroot` does not behave as the original, breaks e.g. aurutils #1

New issue

Open

opened 2019-04-16 21:09:48 +00:00 by ckolumbus · 2 comments

ckolumbus commented

2019-04-16 21:09:48 +00:00

(Migrated from gitlab2.manjaro.org)

mkmanjaroroot is a symlink to mkarchroot, but mkarchroot does not behave as the original Arch version: it creates a file .manjaro-chroot instead of .arch-chroot (see mkarchroot.in Line 109 )

This essentially breaks the API of mkarchroot and other programs depending on this file break. My problem was with aurutils: they check for the correctly created chroot file system by looking for .arch-chroot, which does not exist when using the Manjaro devtools and aurutils fail.

Possible solutions IMHO:

make mkarchroot behave as Arch equivalent, only create .arch-chroot and keep symlink from mkmanjaroroot: this could possibly break some code as manjaro packages now don't find the .manjaro-chroot file anymore.
make mkmanjaroroot create .manjaro-chroot and mkarchroot .arch-chroot (separating the two programs): this could break code that relies on the wrong behavior
make mkarchroot create both files .arch-chroot and .manjaro-chroot and keep symlink: possibly best backward compatibility (but maybe side effects?)

This has also been discussed in the forum

`mkmanjaroroot` is a symlink to `mkarchroot`, but `mkarchroot` does not behave as the original Arch version: it creates a file `.manjaro-chroot` instead of `.arch-chroot` (see [mkarchroot.in Line 109](https://gitlab.manjaro.org/tools/development-tools/devtools/blob/master/mkarchroot.in#L109) ) This essentially breaks the API of `mkarchroot` and other programs depending on this file break. My problem was with [aurutils](https://aur.archlinux.org/packages/aurutils): they check for the correctly created chroot file system by looking for `.arch-chroot`, which does not exist when using the Manjaro devtools and aurutils fail. Possible solutions IMHO: 1. make `mkarchroot` behave as Arch equivalent, only create `.arch-chroot` and keep symlink from `mkmanjaroroot`: this could possibly break some code as manjaro packages now don't find the `.manjaro-chroot` file anymore. 2. make `mkmanjaroroot` create `.manjaro-chroot` and `mkarchroot` `.arch-chroot` (separating the two programs): this could break code that relies on the wrong behavior 3. make `mkarchroot` create *both* files `.arch-chroot` and `.manjaro-chroot` and keep symlink: possibly best backward compatibility (but maybe side effects?) This has also been discussed in the [forum](https://forum.manjaro.org/t/manjaro-version-of-mkarchroot-does-not-behave-as-the-original-breaks-e-g-aurutils/83544)

ckolumbus commented

2019-04-20 20:28:20 +00:00

(Migrated from gitlab2.manjaro.org)

changed the description

ckolumbus commented

2019-04-20 20:28:58 +00:00

(Migrated from gitlab2.manjaro.org)

changed the description