tools/manjaro-tools

Fork 0

[buildiso] graceful exit after errors #104

New issue

Closed

opened 2015-06-07 04:37:00 +00:00 by philm · 12 comments

philm commented

2015-06-07 04:37:00 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: ryanvade

An enhancement suggestion. If an error occurs it would probably be good if cleanup would occur. Remove stale files that can't be removed unless you reboot, for example if pacman can't find a package you want installed to the image.

*Created by: ryanvade* An enhancement suggestion. If an error occurs it would probably be good if cleanup would occur. Remove stale files that can't be removed unless you reboot, for example if pacman can't find a package you want installed to the image.

philm commented

2015-06-07 04:39:22 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: ryanvade

A similar system would be good if you stop the proccess during building ( ctrl + C for example)

*Created by: ryanvade* A similar system would be good if you stop the proccess during building ( ctrl + C for example)

philm commented

2015-06-07 05:42:56 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

@ryanvade: please post about your error you're still facing, as we thought we already implemented it with https://github.com/manjaro/manjaro-tools/issues/78.

*Created by: philmmanjaro* @ryanvade: please post about your error you're still facing, as we thought we already implemented it with https://github.com/manjaro/manjaro-tools/issues/78.

philm commented

2015-06-09 10:09:51 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

@ryanvade

Which version do you use?
The devel branch should be fine, I changed yesterday some checks.
buildiso is not run if it fails profile check or buildset sanity check.

*Created by: udeved* @ryanvade Which version do you use? The devel branch should be fine, I changed yesterday some checks. buildiso is not run if it fails profile check or buildset sanity check.

philm commented

2015-06-10 02:44:10 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: ryanvade

For example, if you add a package to the list which is not able to be installed then you still get image files that can't be deleted due to "Stale File" issues. I also think pressing ctrl + c should stop the application not just the current process. Its not just errors, if a user wants to stop for some reason shouldn't the tools cleanup?

*Created by: ryanvade* For example, if you add a package to the list which is not able to be installed then you still get image files that can't be deleted due to "Stale File" issues. I also think pressing ctrl + c should stop the application not just the current process. Its not just errors, if a user wants to stop for some reason shouldn't the tools cleanup?

philm commented

2015-06-10 07:11:49 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

Which version do you use?

What you describe does not happen with git devel version.

*Created by: udeved* Which version do you use? What you describe does not happen with git devel version.

philm commented

2015-06-10 22:59:19 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: ryanvade

The last time it happened was with manjaro-git-tools built two days ago. I have not had the issue since.

*Created by: ryanvade* The last time it happened was with manjaro-git-tools built two days ago. I have not had the issue since.

philm commented

2015-06-12 22:45:08 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: ryanvade

Just for record this is what I mean:

==> Start building [gnome]
 --> Profile: [gnome]
==> Cleaning up ...
  -> Deleting chroot 'gnome-image'...
rm: cannot remove '/var/lib/manjaro-tools/buildiso/gnome/i686/gnome-image': Device or resource busy
  -> Deleting chroot 'root-image'...
rm: cannot remove '/var/lib/manjaro-tools/buildiso/gnome/i686/gnome-image': Is a directory
 --> Loading Packages: [Packages] ...

Caused by cancelling a previous build then trying again.

*Created by: ryanvade* Just for record this is what I mean: ``` ==> Start building [gnome] --> Profile: [gnome] ==> Cleaning up ... -> Deleting chroot 'gnome-image'... rm: cannot remove '/var/lib/manjaro-tools/buildiso/gnome/i686/gnome-image': Device or resource busy -> Deleting chroot 'root-image'... rm: cannot remove '/var/lib/manjaro-tools/buildiso/gnome/i686/gnome-image': Is a directory --> Loading Packages: [Packages] ... ``` Caused by cancelling a previous build then trying again.

philm commented

2015-06-13 07:30:57 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

For that we need a proper pre-unmount before starting a session.

*Created by: philmmanjaro* For that we need a proper **pre-unmount** before starting a session.

philm commented

2015-06-13 07:56:57 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

Can also be done with umount_handler at build_image calls.

*Created by: udeved* Can also be done with umount_handler at build_image calls.