make buildiso path independent? #153
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#153
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: udeved
We got deployiso being path independent, it can be run from anywhere.
Do we want buildiso to detect the iso-profiles, so it can be run from anywhere too?
Created by: philmmanjaro
Would be nice to have, but how do you search for profiles and save their location for the next time?
Created by: udeved
We would be searching for a unique file in the iso-profiles, eg .manjaro-tools.
However, this doesn't play out well if we have say sonar in $HOME as well.
We could save path in new user config location.
Created by: philmmanjaro
Ok, then step by step. It doesn't have to be in 0.9.15. There is no rush for it.
I agree, would be great to have! For me it would be sufficient to have a default location for iso-profiles and the option to change the path in manjaro-tools.conf manually.
Created by: udeved
I got a working buildiso being path independent.
We should think about how to detect or tell buildiso what iso-profiles directory it is supposed to use.
The easiest would be to configure it in a variable, but I think a detection is better, that stores the path in a file, eg in $HOME/.config/manjaro-tools/iso-profiles.conf
Created by: udeved
Some thoughts.
In order to detect iso profiles repos, we need a consistent naming for repo additions.
eg
manjaro-iso-profiles
netrunner-iso-profiles
sonar-iso-profiles
I had some test, where detected repo paths are written to a $HOME/.config/manjaro-tools/$repo.conf
The difficulty is to set $repo without a consistent naming.
If we have a repo name, we could add it to manjaro-tools.conf, ie repo=manjaro, repo=netrunner, repo=sonar
Created by: udeved
Ok, it now also works with any repo name.
Upon buildiso run, it tries to detect iso-profiles repos in $HOME, we can have it use /usr/share/manjaro-tools/iso-profiles if nothing is found in $HOME.
If found, it writes a $reponame.conf with run_dir=$path that is sourced.
To select repo, it has to be defined in manjaro-tools.conf.
I am tempted to merge iso branch in devel branch, since we don't use new repo structure yet, and both branches require new repo structure.