Clean chroot now with every build? #157
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#157
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: philmmanjaro
I noticed now that we clean-up the chroot on every build. Is this now default and wanted?
Created by: udeved
Not that I am aware of.
But, we changed the git version in the scripts to have a git id rather than version number.
This causes check_chroot to recreate the chroot, because the version check detects new chroot version.
Perhaps its not ideal for our git package to have a git version variable.
Created by: philmmanjaro
No, I'm talking about the regular build. Maybe it doesn't like to have 0.9.15-rc1 as version. Simply install the current non-git-version and try to build a package. It will recreate the chroot every time. That's why I was wondering ...
Created by: udeved
Hmm, it works for me with git version, updating chroot works on my end.
Please review
github.com/manjaro/packages-extra@a70c0855b9Created by: philmmanjaro
Will check that later ...
Created by: philmmanjaro
Hmm, the latest changes gave me now this:
Will check what will happen next if I build another package in the same chroot. The funny thing is, I'm doing unstable here. Some is wrong with the check.
Created by: philmmanjaro
Ah, forget the stable cmd. manjaro-tools.conf changed it's location. I forgot about that.
Created by: philmmanjaro
Ok, I can confirm: removing the check doesn't do anything. It still deletes the chroot on each build of a package. So we have to fix this issue on systemd systems.
Created by: philmmanjaro
I'm stupied. Did again a -c build ... Tilt.