tools/manjaro-tools
3
0
Fork 0
Code Issues 3 Pull requests Projects Releases 51 Packages Wiki Activity Actions

[manjaro-tools.conf] iso_name useless var? #163

New issue
Closed
opened 2015-12-18 22:49:13 +00:00 by philm · 1 comment
philm commented 2015-12-18 22:49:13 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: udeved

As it is now, we have two very similar variables, that is
iso_name
dist_name

We currently mix them in code.
Is there any reason we shouldn't remove iso_name from configuration?

Usecase is:

iso_name=manjaro
dist_name=Manjaro

iso_name=sonar
dist_name=Sonar

We can achieve the same by converting dist_name to lower cases, and let iso_name be non configurable, but determined by dist_name.

*Created by: udeved* As it is now, we have two very similar variables, that is iso_name dist_name We currently mix them in code. Is there any reason we shouldn't remove iso_name from configuration? Usecase is: iso_name=manjaro dist_name=Manjaro iso_name=sonar dist_name=Sonar We can achieve the same by converting dist_name to lower cases, and let iso_name be non configurable, but determined by dist_name.
philm commented 2015-12-19 09:03:20 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: philmmanjaro

Fine. Simplify it then ...

*Created by: philmmanjaro* Fine. Simplify it then ...
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
fhdk-master-patch-fbfa
fhdk-master-patch-3143
gaming-2025
ext4
no-display
gaming
345-avoid-the-dev-loop0-busy-condition
stable-0.15.x
gnome-initial-setup
volid
experimental
devel
master-April-15-2018
revert-284-master
master-June-11-2017
stable-0.14.x
arch-patch
stable-0.13.x
stable-0.12.x
stable-0.11.x
0.15.13
0.15.12
0.15.11
0.15.10
0.15.9
0.15.8
0.15.7
0.15.6
0.15.5
0.15.4
0.15.3
0.15.2
0.15.1
0.15.0
0.14.7
0.14.6
0.14.5
0.14.4
0.14.3
0.14.2
0.14.1
0.14.0
0.13.8
0.13.7
0.13.6
0.13.5
0.13.4
0.13.3
0.13.2
0.12.4
0.13.1
0.12.3
0.13.0
0.12.2
0.12.1
0.12.0
0.11.903
0.11.902
0.11.901
0.11.7
0.11.6
0.11.5
0.11.4
0.11.3
0.11.2
0.11.1
0.11.0
0.10.3
0.10.2
0.10.1
0.10.0
0.9.15
0.9.14-1
0.9.13.2-1
0.9.13.1-1
0.9.13-1
0.9.12-1
0.9.11-3
0.9.11-2
0.9.11
0.9.10
0.9.9
0.9.8
0.9.7.4
0.9.7.3
0.9.7.2
0.9.7.1
0.9.7
0.9.6.4
0.9.6.3
manjaro-tools-0.9.6.2
manjaro-tools-0.9.6.1
manjaro-tools-0.9.6
manjaro-tools-0.9.5.7
manjaro-tools-0.9.5.6
manjaro-tools-0.9.5.5
manjaro-tools-0.9.5.4
manjaro-tools-0.9.5.3
manjaro-tools-0.9.5.2
manjaro-tools-0.9.5.1
manjaro-tools-0.9.5
manjaro-tools-0.9.4.3
manjaro-tools-0.9.4.2
manjaro-tools-0.9.4.1
manjaro-tools-0.9.4
manjaro-tools-0.9.3.1
manjaro-tools-0.9.3
manjaro-tools-0.9.2
manjaro-tools-0.9.1.1
manjaro-tools-0.9.1
manjaro-tools-0.9
manjaro-tools-0.8.1
manjaro-tools-0.8
Labels
Clear labels   
Done

   
bug

   
buildiso

   
buildpkg

   
buildtree

   
critical

   
deployiso

   
duplicate

   
enhancement

   
help wanted

   
in progress

   
invalid

   
manjaro-chroot

   
note

   
old-not-relevant

   
optional

   
question

   
sonar

   
todo

   
wontfix
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
Milestone
Clear milestone
No items
No milestone
0.10.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tools/manjaro-tools#163
No description provided.