manjaro-tools-iso-git-r1918.a300acd-1 stopps after de-image creation with error #189
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#189
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: philmmanjaro
Seems some is wrong within manjaro-tools-iso-git-r1918.a300acd-1. It simply stops after de-image creation with an error message. Using however manjaro-tools-iso-git-r1909.6a8a408-1 with the same profile, the ISO get created.
Created by: udeved
Related to #45
Created by: philmmanjaro
Well, it happens even without logging.
Created by: udeved
See my last comment, its the wrapper function I guess.
Created by: philmmanjaro
I think it is more or less the run_safe function ...
Created by: udeved
Right, but we can easily debig this...
Comment out
in util-iso-image.sh
Created by: udeved
Created by: philmmanjaro
Hmm, now I wonder why it slipped thru in older versions ...
github.com/manjaro/manjaro-tools-iso-profiles@f30934f1c0Created by: udeved
because we suppressed output, and the wrapper function has an exit trap, that seems to influence exit codes of calls.
Created by: udeved
So how does MM get activated properly on systemd?
Created by: philmmanjaro
Well it was not installed in sonar editions. We should check the warper function again. Catching the error code is ok, but then we should know where to look. in kde-minimal for example I get it cos cups is not installed and I try to activate it ...
Created by: udeved
The exit trap is basically cool, we can expand it for #174.
Good opportunity to make the exits safe.
Created by: udeved
We need to check if the service file exists.
Created by: philmmanjaro
I don't complain about the error exit. This is great and wanted. However we should print out the error at least.
Created by: udeved
Hang on, we need to remove all stderr to /dev/null stuff.
Created by: udeved
This needs to go so we get errors printed.
Created by: philmmanjaro
Take your time. No pressure.
Created by: udeved
Just pushed the logger to tackle this.
It was expected to produce all kind of little errors. ;)
Created by: philmmanjaro
And it seemed it worked just fine ...
Created by: udeved
The basic logging ability works fine,yes. :)
Created by: udeved
With the last commits, kde-minimal builds for me with systemd.