[buildpkg] pkgver() not updating pkgver #198
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#198
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
resulting in errors:
I have to run makepg first to have pkgver update...
Created by: udeved
By design it does not update unversioned packages.
What do you mean by an unversioned package? So desktop-settings-community is unversioned?
To be able to build any package with git versions do we really need to run
makepkg -oon it first? That does not sound very practical.Created by: udeved
Yes, or simply set the version.
git packages are not really supposed to be in repo.
This is sane to not update git package version or date version in chroot.
Created by: philmmanjaro
Hold on. Show me the PKGBUILD. With pacman 5.0 the prepare step is done before pkgver. I had to change that also on our calamares-dev PKGBUILD ...
Created by: udeved
Right Phil, you can see eg with manjaro-tools-git pkg, it will aöways show you one commit earlier since pacman 5
Created by: philmmanjaro
What do you mean with one commit earlier?
Created by: philmmanjaro
I see no error here:
Created by: udeved
Phil, say you build manjaro-tools-git with makepkg
The pkgver will have the latest commit, but the scripts will have the version of the previous commit set.
We should change the sed to be _ver rather than the commit.
Created by: philmmanjaro
Let me check that ...
Created by: philmmanjaro
Do I miss here some? On my end it is as expected. Latest git commit in devel is: r1979.1dc80fc
That is what I got with pkgbuild:
Same as with makepkg:
You simply have to clean your dir before building.
Created by: udeved
Now look in the scripts if they have a matching version at the top, eg buildpkg
Created by: udeved
Point being, we shouldn't set the version in the scripts to be git, we should set it to manjaro-tools release version.
This version is used to check chroot version, and you constantly get to update chroot if it have git commit.
Created by: udeved
It should look like this with git pkg...
Created by: philmmanjaro
I think more or less only makepkg will update the PKGVER in PKGBUILD, but not buildpkg. So I don't care about that ...
Created by: udeved
right, and its correct only makepkg does it.
Created by: philmmanjaro
The other thing we can change, if needed. Also for me it doesn't bother if we have to rebuild the chroot for a git-version. Sometimes even needed ...
Created by: udeved
Its just changing PKGBUILD.
The downside with setting a git commit for chroot version is, that you can't use existing chroot, despite its also being 0.11.3
Created by: philmmanjaro
Right, then we change it as needed. But this is connected with the pkg version or how does manjaro-tools check the version?
Created by: udeved
The chroot hosts a .manjaro-tools file, that holds the version that is at top of the scripts, and you see displayed on -q switch.
Created by: udeved
We should do this, rather than setting pkgver for git pkg...
I use this for my git builds.
Created by: philmmanjaro
Ok, add it to the PKGBUILD then.
Created by: udeved
github.com/manjaro/packages-extra@957f6f28ba