Fix error handling #230

New issue

Closed

opened 2016-06-18 08:10:59 +00:00 by philm · 2 comments

philm commented

2016-06-18 08:10:59 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

The error handling introduced with github.com/manjaro/manjaro-tools@52ce7f86be creates issues. See also my efforts to fix it, as I found following error:

[phil@manjaro manjaro-tools-iso-profiles]$ buildiso -p kde-minimal -a i686 -qv
/usr/bin/buildiso: line 200: trap_exit: command not found

Master will quit now with:

[phil@manjaro manjaro-tools-iso-profiles]$ buildiso -p kde-minimal -qv
==> ERROR: An unknown error has occurred. Exiting...

*Created by: philmmanjaro* The error handling introduced with https://github.com/manjaro/manjaro-tools/commit/52ce7f86befcdce48dfea0e42539ac954971d840 creates issues. See also [my efforts](https://github.com/manjaro/manjaro-tools/compare/0.12.0...master) to fix it, as I found following error: ``` [phil@manjaro manjaro-tools-iso-profiles]$ buildiso -p kde-minimal -a i686 -qv /usr/bin/buildiso: line 200: trap_exit: command not found ``` Master will quit now with: ``` [phil@manjaro manjaro-tools-iso-profiles]$ buildiso -p kde-minimal -qv ==> ERROR: An unknown error has occurred. Exiting... ```

philm commented

2016-06-19 20:55:38 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

I get clean build in 0.12.2 branch.
Wasn't sure about the state of master, since merge conflicts I didn't pull master and branched out.

*Created by: udeved* I get clean build in 0.12.2 branch. Wasn't sure about the state of master, since merge conflicts I didn't pull master and branched out.

philm commented

2016-06-20 06:33:32 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Ok, I pulled you changes after removing my changes. Currently testing it. Seems to be fine.

*Created by: philmmanjaro* Ok, I pulled you changes after removing my changes. Currently testing it. Seems to be fine.