Decide what to do with master and development code

philm commented

2017-11-01 19:03:51 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

We should review both branches and decide what to do about them.

*Created by: philmmanjaro* We should review both branches and decide what to do about them.

oberon commented

2017-11-01 19:08:12 +00:00

(Migrated from gitlab2.manjaro.org)

I think it makes little sense to move to dev branch. It is very different and when I last tested there were some issues afai remember.
diff is huge and practically impossible to compare ...
master seems to be working fine. I would opt to stick with it and go from there.

I think it makes little sense to move to dev branch. It is very different and when I last tested there were some issues afai remember. diff is huge and practically impossible to compare ... master seems to be working fine. I would opt to stick with it and go from there.

philm commented

2017-11-01 19:13:00 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Master has to be reviewed also. We will see when we find time. I've released v0.15.4 for now.

*Created by: philmmanjaro* **Master** has to be reviewed also. We will see when we find time. I've released **v0.15.4** for now.

oberon commented

2017-11-01 19:20:59 +00:00

(Migrated from gitlab2.manjaro.org)

ah well I meant master 😉

oberon commented

2017-11-01 19:24:24 +00:00

(Migrated from gitlab2.manjaro.org)

I don't see why we need to move everything again to different files, change var names. It's like starting over again. The diff is a total mess. No idea why we would need to do that.

philm commented

2017-11-01 19:27:14 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Maybe some good code is there. Else we ditch it and go with v0.15.4 ;)

*Created by: philmmanjaro* Maybe some good code is there. Else we ditch it and go with **v0.15.4** ;)

philm commented

2017-11-01 21:13:03 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: Chrysostomus

Just read through the diff. Much moving code around. Help command gives info about -U flag. Cleaning out the parts that configure thus. Some work towards supporting calamares netinstall better.

If master works as is and devel does not, I would stick with master and ditch devel. Maybe incorporate some specific commits. But in principle take master and work forward from there.

Btw, is netinstall with calamares something that we are actively working towards, or was that more of artoos own thing?

*Created by: Chrysostomus* Just read through the diff. Much moving code around. Help command gives info about -U flag. Cleaning out the parts that configure thus. Some work towards supporting calamares netinstall better. If master works as is and devel does not, I would stick with master and ditch devel. Maybe incorporate some specific commits. But in principle take master and work forward from there. Btw, is netinstall with calamares something that we are actively working towards, or was that more of artoos own thing?

philm commented

2017-11-01 21:14:49 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

I think the net-install got modified upstream already, so we have to check if it still works. Anyway, if we find some useful code, we may use it. I had no time yet to even review the master changes yet.

*Created by: philmmanjaro* I think the **net-install** got modified upstream already, so we have to check if it still works. Anyway, if we find some useful code, we may use it. I had no time yet to even review the **master** changes yet.

oberon commented

2017-11-01 21:26:04 +00:00

(Migrated from gitlab2.manjaro.org)

my understanding is that we were considering to go on from stable-15.x branch - which is again a LOT different from master! 😉

philm commented

2017-11-01 21:27:30 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Yep. That was the old code. Master was some like v0.16.0 ish, which might need some backports from v0.15 series. If no need we may ditch both and stick with v0.15.

*Created by: philmmanjaro* Yep. That was the old code. Master was some like **v0.16.0** ish, which might need some backports from **v0.15** series. If no need we may ditch both and stick with **v0.15**.

yochananmarqos1 commented

2025-10-05 22:39:39 +00:00

(Migrated from gitlab2.manjaro.org)

Closing stale issue

yochananmarqos1 (Migrated from gitlab2.manjaro.org) closed this issue

2025-10-05 22:39:40 +00:00

Rows
Columns

Decide what to do with master and development code #276