tools/manjaro-tools

Fork 0

[mkchroot] revisit locale-gen #37

New issue

Closed

opened 2015-01-20 06:11:40 +00:00 by philm · 12 comments

philm commented

2015-01-20 06:11:40 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

By default we have followed locale.conf

LANG=en_US.utf8
LC_COLLATE=C

Somehow we end up with:

LANG=C

This is wrong and needs another look. Also it might create lot of issues during live-session bootup.

*Created by: manjaro* By default we have followed locale.conf <pre>LANG=en_US.utf8 LC_COLLATE=C</pre> Somehow we end up with: <pre>LANG=C</pre> This is wrong and needs another look. Also it might create lot of issues during live-session bootup.

philm commented

2015-01-20 07:54:35 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

6108431a6e might fix it. Needs testing ...

*Created by: manjaro* 6108431a6e0cd43f20b158a14c3843de683cbc95 might fix it. Needs testing ...

philm commented

2015-01-20 12:58:35 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

This is only default for buildpkg, ie build_locale=true (-L)

buildiso calls mkchroot without -L

Will take a look later.

*Created by: udeved* This is only default for buildpkg, ie build_locale=true (-L) buildiso calls mkchroot without -L Will take a look later.

philm commented

2015-01-20 14:33:09 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

I get errors in live-session bootup regarding C locale. I've to check my buildiso work folder later when I'm home.

*Created by: manjaro* I get errors in live-session bootup regarding C locale. I've to check my buildiso work folder later when I'm home.

philm commented

2015-01-20 16:39:54 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

If I output the concerning vars for mkchroot at iso build I get this:

-> build_locales: false
-> build_mirror:

which is correct for buildiso.

Will investigate further, but code wise, no lang.conf or locale is changed or set for buildiso.
No locale.conf is written at all, so iso may default to standard locales.

I think we should run also locale-gen with default english, atm it runs "empty"(commented) locale.gen.
It will be set again by livecd script I recall.

*Created by: udeved* If I output the concerning vars for mkchroot at iso build I get this: ``` -> build_locales: false -> build_mirror: ``` which is correct for buildiso. Will investigate further, but code wise, no lang.conf or locale is changed or set for buildiso. No locale.conf is written at all, so iso may default to standard locales. I think we should run also locale-gen with default english, atm it runs "empty"(commented) locale.gen. It will be set again by livecd script I recall.

philm commented

2015-01-20 17:22:52 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

github.com/manjaro/manjaro-tools@7ec1ea51cf

I believe this commit fixes it.
Please test also.

Your commit essentially changed locales for buildpkg but not for buildido call.

*Created by: udeved* https://github.com/manjaro/manjaro-tools/commit/7ec1ea51cf7d0535c41f699082beb94b2d8e226a I believe this commit fixes it. Please test also. Your commit essentially changed locales for buildpkg but not for buildido call.

philm commented

2015-01-20 17:45:42 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

I check it now. As of now no locales get generated. I've to check if some are needed at all.

*Created by: manjaro* I check it now. As of now no locales get generated. I've to check if some are needed at all.

philm commented

2015-01-20 18:07:40 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

The locale.conf on root-image is now created as expected.

LANG=en_US.UTF-8
LC_MESSAGES=C

and locale-gen is set to

en_US.UTF-8 UTF-8

and en locales generated.

Looks fine to me. The iso now is set to default english and probably won't default to C locales due to unset loacles.

*Created by: udeved* The locale.conf on root-image is now created as expected. ``` LANG=en_US.UTF-8 LC_MESSAGES=C ``` and locale-gen is set to ``` en_US.UTF-8 UTF-8 ``` and en locales generated. Looks fine to me. The iso now is set to default english and probably won't default to C locales due to unset loacles.

philm commented

2015-01-20 18:11:37 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

Well it works. We need to add routine to start locale-gen only after we created root-image and only for that image, else we have it on all images.

*Created by: manjaro* Well it works. We need to add routine to start locale-gen only after we created root-image and only for that image, else we have it on all images.

philm commented

2015-01-20 18:38:14 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

Urgs, then mkchroot has to check if root-image is in the work_dir path.
or we simply delete locale.gen and locale.conf on other images.

But do they hurt or confuse the system?

*Created by: udeved* Urgs, then mkchroot has to check if root-image is in the work_dir path. or we simply delete locale.gen and locale.conf on other images. But do they hurt or confuse the system?

philm commented

2015-01-20 20:52:36 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

Getting closer now 89b0396159

*Created by: manjaro* Getting closer now 89b0396159de1518a9586d40f7c22276979377c3

philm commented

2015-01-20 22:49:07 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: manjaro

finally fixed with 3069853560

*Created by: manjaro* finally fixed with 306985356091fa88e0c158feb2194b7fae881a3f