[buildiso/conf] Introduce branding #70
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#70
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: udeved
We need branding.
Created by: philmmanjaro
I just talked to Kyle from Sonar Linux and he told me that changing username, password and hostname in our config file doesn't do anything. We have to actually check it once more. Also we have to check how to create efiboot loader entries on the fly as they are now hardcoded to Manjaro in our shared/profiles folder.
Created by: udeved
I can't see anything wrong with user, password and host, we also call the configure stuff.
Is this with the latest changes and profile.conf?
As for efi, please elaborate, I didn't really get it.
Created by: udeved
I see, you want the efiboot directory and content on the fly?
I already started with that btw, I will push a bigger changeset, its mainly variable renaming.
So check your profile.conf and manjaro-tools.conf.
Profiles and cli are also updated with new var names.
Created by: udeved
Var renaming:
manjaro_kernel --> dist_kernel
manjaro_kernel_ver --> dist_kernel_ver
manjaroiso --> dist_iso
manjaro_version --> dist_version
Created by: udeved
Ok, one TODO left.
We need a better approach for generating the mkinitcpio image.
Currently we determine kernel modules version to use -k switch, but I think its better to create a preset with the $dist_kernel we already know with profile.conf.
Created by: udeved
Changes overview:
efi entries are now created on the fly and would in theory support 32bit efi.
isolinux.cfg is also created on the fly, but a isolinux-overlay cfg will overwrite the generated one.
Created by: philmmanjaro
Regarding the hostname, password, username. Sonar linux guys claim that with changing that their iso won't boot up. Did you ever tried to change username, host and password from default?
Created by: udeved
I tried some time ago and it used to work.
Will check again.
Created by: philmmanjaro
Ok, maybe then there was something else. They are both blind, so something might got mis-interpreted by them. We will figure it out when branding is done and tested by us.
Created by: udeved
Phil, could you test a custom hostname for a systemd iso please?
Its the only thing I can think of why a boot process would hang on systemd, meybe.
PS: the dynamic boot file writing seems to work.
Will test next custom values for the branding stuff
Created by: philmmanjaro
Ok, will do when I find time. So, I assume you have this now on the devel branch and latest code tested. Will do the same later on.
Created by: udeved
Yes, latest code.
I will also test the new mkinitcpio preset image generation.
Its ugly to check for kernel version in /usr/lib/modules .... as it is now.
Created by: philmmanjaro
On which part do we do that?
Created by: udeved
I just committed a better solution.
It was left over code from manjaroiso.
Created by: udeved
Appears to be working ;)
Created by: udeved
Ok, last thing is also done, the isolinux message file.
Now, I do think we got the branding stuff too much cluttered.
We got in:
Could we reduce some variables, such as install_dir equals img_name?
Created by: philmmanjaro
yes, simplify it as much as you can.
Created by: udeved
I close this, last commits did it and objective is met now.