[buildiso] on error we should stop and not go on #78

Closed
opened 2015-03-15 11:10:53 +00:00 by philm · 8 comments
philm commented 2015-03-15 11:10:53 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Currently we have the situation that buildiso still goes on, even we had an error. It normally should stop working in such a case ...

*Created by: philmmanjaro* Currently we have the situation that **buildiso** still goes on, even we had an error. It normally should stop working in such a case ...
philm commented 2015-03-15 11:29:31 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Example:
On make_image_xorg step a package can't be downloaded. We should stop here when it happend and not go on with repo-add:

 lib32-mesa-10.4.6-1...     4.2 MiB  3.46M/s 00:01 [######################] 100%
error: failed retrieving file 'lib32-nvidia-utils-346.47-1-x86_64.pkg.tar.xz' from repo.manjaro.org : Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds
warning: failed to retrieve some files
 lib32-libxv-1.0.10-...     7.2 KiB  2.34M/s 00:00 [######################] 100%
 lib32-libxvmc-1.0.8...    10.3 KiB  3.35M/s 00:00 [######################] 100%
error: failed to commit transaction (unexpected error)
Errors occurred, no packages were upgraded.
  -> Copying xorg pkgs cache ...
==> Adding package '/opt/buildiso/xfce-minimal/x86_64/pkgs-image/opt/livecd/pkgs/bumblebee-3.2.1-5-x86_64.pkg.tar.xz'
  -> Computing checksums...

So we have to find a way to catch pacman errors.

*Created by: philmmanjaro* **Example**: On **make_image_xorg** step a package can't be downloaded. We should stop here when it happend and not go on with repo-add: <pre> lib32-mesa-10.4.6-1... 4.2 MiB 3.46M/s 00:01 [######################] 100% error: failed retrieving file 'lib32-nvidia-utils-346.47-1-x86_64.pkg.tar.xz' from repo.manjaro.org : Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds warning: failed to retrieve some files lib32-libxv-1.0.10-... 7.2 KiB 2.34M/s 00:00 [######################] 100% lib32-libxvmc-1.0.8... 10.3 KiB 3.35M/s 00:00 [######################] 100% error: failed to commit transaction (unexpected error) Errors occurred, no packages were upgraded. -> Copying xorg pkgs cache ... ==> Adding package '/opt/buildiso/xfce-minimal/x86_64/pkgs-image/opt/livecd/pkgs/bumblebee-3.2.1-5-x86_64.pkg.tar.xz' -> Computing checksums... </pre> So we have to find a way to catch pacman errors.
philm commented 2015-03-15 11:31:34 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Example:
During working on #76 we found some other issue. In that case mkinitcpio created an error:

==> Done [pkgs-image]
==> Prepare [manjaro/boot]
  -> mount [boot-image] on [xfce-image]
  -> append [root-image] on [boot-image]
  -> Copying initcpio ...
==> ERROR: '/lib/modules/3.18.9-1-MANJARO' is not a valid kernel module directory
mv: cannot stat '/opt/buildiso/xfce-minimal/x86_64/boot-image/boot/manjaro.img': No such file or directory
  -> unmount boot-image
==> Done [manjaro/boot]
==> Prepare [manjaro/boot/EFI]
  -> Copying efi loaders ...
  -> Writing loader.conf ...

Also here buildiso should have stopped and not going on to produce efi-boot ...

*Created by: philmmanjaro* **Example**: During working on #76 we found some other issue. In that case **mkinitcpio** created an error: <pre>==> Done [pkgs-image] ==> Prepare [manjaro/boot] -> mount [boot-image] on [xfce-image] -> append [root-image] on [boot-image] -> Copying initcpio ... ==> ERROR: '/lib/modules/3.18.9-1-MANJARO' is not a valid kernel module directory mv: cannot stat '/opt/buildiso/xfce-minimal/x86_64/boot-image/boot/manjaro.img': No such file or directory -> unmount boot-image ==> Done [manjaro/boot] ==> Prepare [manjaro/boot/EFI] -> Copying efi loaders ... -> Writing loader.conf ... </pre> Also here **buildiso** should have stopped and not going on to produce **efi-boot** ...
philm commented 2015-03-15 11:34:27 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Seems it misses stderr and is related to #45.

*Created by: philmmanjaro* Seems it misses **stderr** and is related to #45.
philm commented 2015-03-15 12:28:41 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: aadityabagga

Thx, this was a long standing issue for me :)

*Created by: aadityabagga* Thx, this was a long standing issue for me :)
philm commented 2015-06-28 11:24:52 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

https://github.com/manjaro/manjaro-tools-iso-profiles/issues/40 clearly shows that this issue is still not solved.

*Created by: philmmanjaro* https://github.com/manjaro/manjaro-tools-iso-profiles/issues/40 clearly shows that this issue is still not solved.
philm commented 2015-06-29 10:21:47 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: udeved

Please test, I have not managed with these changes to get a still mounted image on error.
After this can was closed, I would do a 0.9.10 fix release.

*Created by: udeved* Please test, I have not managed with these changes to get a still mounted image on error. After this can was closed, I would do a 0.9.10 fix release.
philm commented 2015-06-30 20:30:31 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: udeved

Seems to work after some reports too.

*Created by: udeved* Seems to work after some reports too.
philm commented 2015-06-30 20:45:26 +00:00 (Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Great news, mate ;)

*Created by: philmmanjaro* Great news, mate ;)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tools/manjaro-tools#78
No description provided.