[buildiso] split caching xorg-pkgs from -c switch #81

New issue

Closed

opened 2015-04-05 07:57:36 +00:00 by philm · 6 comments

philm commented

2015-04-05 07:57:36 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Currently if we pass buildiso xorg-pkg-cache gets deleted, always. Normally it should been kept. You want to delete only your build folders. Add a -x or -g switch for deleting xorg-pkg-cache if the user wants it.

*Created by: philmmanjaro* Currently if we pass **buildiso** xorg-pkg-cache gets deleted, always. Normally it should been kept. You want to delete only your build folders. Add a -x or -g switch for deleting xorg-pkg-cache if the user wants it.

philm commented

2015-04-05 08:05:45 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: Kirek

We currently don't detect if xorg-pkg-cache is outdated or not, so I think the current behaviour to delete it by default is the correct one.
-x switch keeps the xorg cache.

*Created by: Kirek* We currently don't detect if xorg-pkg-cache is outdated or not, so I think the current behaviour to delete it by default is the correct one. -x switch keeps the xorg cache.

philm commented

2015-04-09 17:38:52 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

I agree with Kirek.
the lng and xorg cache are not version aware.
For example, if some xorg package has a new release and you don't clean the cache, you end up having both versions on the iso. This can quickly increase size considerably.
We can use perhaps some version function from utils to do checks, but I am not really keen to implement such thing. Pacman also doesn't do it.

*Created by: udeved* I agree with Kirek. the lng and xorg cache are not version aware. For example, if some xorg package has a new release and you don't clean the cache, you end up having both versions on the iso. This can quickly increase size considerably. We can use perhaps some version function from utils to do checks, but I am not really keen to implement such thing. Pacman also doesn't do it.

philm commented

2015-04-09 20:38:53 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Ok, I got it now.

*Created by: philmmanjaro* Ok, I got it now.

philm commented

2015-04-10 07:51:20 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

My consideration to implement this would lean to pacman, that should get such feature.
If new package, pacman deletes old one except specified otherwise. Something like this. :)

*Created by: udeved* My consideration to implement this would lean to pacman, that should get such feature. If new package, pacman deletes old one except specified otherwise. Something like this. :)

philm commented

2015-04-10 09:05:02 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: Kirek

I thing the problem with the xorg cache is that it downloads all packages every time the xorg cache is created, instead of using the pacman cache...

*Created by: Kirek* I thing the problem with the xorg cache is that it downloads all packages every time the xorg cache is created, instead of using the pacman cache...

philm commented

2015-04-10 13:40:59 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: udeved

Yep kirek, we basically just change the pacman cache location. pacman treats it just like normal cache dir. I think we could do such checks with the functions in util.sh, but in my view, the better place to address this was pacman itself.

*Created by: udeved* Yep kirek, we basically just change the pacman cache location. pacman treats it just like normal cache dir. I think we could do such checks with the functions in util.sh, but in my view, the better place to address this was pacman itself.