[buildiso] (optimization) Trim Xorg pkg cache before copying to ISO? #86
Labels
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
tools/manjaro-tools#86
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: aadityabagga
Currently, whichever packages are present in Xorg pkg cache are directly copied over to the ISO.
Can it be made like pacman cache, such that only the latest packages in cache are copied over?
One way to do this in my opinion would be to use
paccacheon the copied the repo, so that old versions of packages get removed, like:Pull request https://github.com/manjaro/manjaro-tools/pull/85
Not completely tested though.
Created by: philmmanjaro
This makes sense. On my end though the xorg-cache gets always deleted. Please test it and post your result like:
Created by: aadityabagga
I can confirm something similar happened here too.
I am building and checking at which point the Xorg pkgs get erased.
Dont know if it happened on making above change or was it broken before..
Created by: aadityabagga
Hmm, this time the packages in xorg cache did not get deleted.
Maybe I had made some mistake the first time..
I used it as follows:
geniso used above is a wrapper for buildiso which removes custom repo from pacman.conf while building.
Created by: philmmanjaro
Do you use the -c switch in any way?
Created by: philmmanjaro
Anyway, your changes don't harm:
Please test on your end, if they work for you.
Created by: aadityabagga
I get the same output as above.
Yes, I used -c.
This is the script I used:
https://forum.manjaro.org/index.php?topic=20637.msg198256#msg198256
I will do more testing with this commit and try to find any issues.
Created by: philmmanjaro
Then xorg-cache is kept and it is logical ...
Created by: aadityabagga
I generated some more ISOs and did not face again the issue of Xorg cache being removed.
I will try to do more testing, especially when there is more than one version of a package in xorg cache, before closing this.
Created by: udeved
This one looks good @aadityabagga
I like it, it removed outdated packages I had in xorg cache.
Remember all, that now cleaning cache must be enabled with -x/-l respectively as opposed to default cleaning previously..
We can reopen at any time, but looks to be working fine so far.