applications/manjaro-hello
3
0
Fork 0
Code Issues Pull requests Projects Releases 40 Packages Wiki Activity Actions

WIP: Draft: fix deprecated set_margin_left() #148

Closed
fhdk wants to merge 0 commits from master into master
pull from: master
merge into: applications:master
Conversation 26 Commits - Files changed -
fhdk commented 2024-07-28 05:39:31 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Change deprecated set_margin_left() to set_margin_start(). Applied
source code formatting PEP and for readability of function
descriptions.

Part of https://gitlab.manjaro.org/applications/manjaro-hello/-/issues/43

Change deprecated set_margin_left() to set_margin_start(). Applied source code formatting PEP and for readability of function descriptions. Part of https://gitlab.manjaro.org/applications/manjaro-hello/-/issues/43
fhdk commented 2024-07-28 05:41:05 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

changed the description

changed the description
fhdk commented 2024-07-28 08:20:53 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • c5839211 - Refactor dependencies and add exception handling

Compare with previous version

added 1 commit <ul><li>c5839211 - Refactor dependencies and add exception handling</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4226&start_sha=101651b413d48941b7f290f0d5759bffbbe1d4d4)
fhdk commented 2024-07-28 08:27:37 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 0b38ca9d - Update button labels in UI glade file

Compare with previous version

added 1 commit <ul><li>0b38ca9d - Update button labels in UI glade file</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4227&start_sha=c583921149efbc26ce2785b391c0505d6cef339c)
fhdk commented 2024-07-28 12:31:44 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
fhdk commented 2024-07-28 12:32:43 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

requested review from @codesardine

requested review from @codesardine
fhdk commented 2024-07-28 12:33:13 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

assigned to @fhdk

assigned to @fhdk
fhdk commented 2024-07-28 12:35:49 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 4h of time spent

added 4h of time spent
fhdk commented 2024-07-28 12:53:10 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

requested review from @ste74

requested review from @ste74
fhdk commented 2024-07-28 15:33:24 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • b9960236 - Update version property to use a variable

Compare with previous version

added 1 commit <ul><li>b9960236 - Update version property to use a variable</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4231&start_sha=0b38ca9de069ebf8fbe6a4f778a3cb41533e14b5)
fhdk commented 2024-07-28 15:44:23 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 7f15dbd0 - Replace deprecated icon_name with Gtk.Image in buttons

Compare with previous version

added 1 commit <ul><li>7f15dbd0 - Replace deprecated icon_name with Gtk.Image in buttons</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4232&start_sha=b9960236d4c5f5e01c08bca7b66a4b43919f062f)
fhdk commented 2024-07-28 15:47:21 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 4e052266 - Fix typo in Gtk.Image stock identifier

Compare with previous version

added 1 commit <ul><li>4e052266 - Fix typo in Gtk.Image stock identifier</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4233&start_sha=7f15dbd075eacf46288abc4881192c5064594d6e)
fhdk commented 2024-07-28 15:48:54 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
fhdk commented 2024-07-28 15:51:58 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 24bd08f4 - Update icon for back buttons to use Gtk.STOCK_GO_BACK

Compare with previous version

added 1 commit <ul><li>24bd08f4 - Update icon for back buttons to use Gtk.STOCK_GO_BACK</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4235&start_sha=4e052266531917bdcd55a4d1e6d02d79ecdb942a)
fhdk commented 2024-07-28 15:59:24 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 44e78be7 - Update icon for back buttons to use Gtk.STOCK_GO_BACK

Compare with previous version

added 1 commit <ul><li>44e78be7 - Update icon for back buttons to use Gtk.STOCK_GO_BACK</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4237&start_sha=24bd08f47f1cb1cc2883d13d32d61d2f7875ebb8)
fhdk commented 2024-07-28 16:04:56 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • b5289372 - Comment out redundant code in application browser

Compare with previous version

added 1 commit <ul><li>b5289372 - Comment out redundant code in application browser</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4239&start_sha=44e78be757a547f509d3746f86524a63be83677c)
fhdk commented 2024-07-28 16:17:30 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 67c997f5 - Add logging for app initialization and error handling

Compare with previous version

added 1 commit <ul><li>67c997f5 - Add logging for app initialization and error handling</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4240&start_sha=b528937206147a9263fe6a6db1d5df2d82481ce1)
fhdk commented 2024-07-28 16:20:22 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 045496b3 - Log app display state for debugging

Compare with previous version

added 1 commit <ul><li>045496b3 - Log app display state for debugging</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4241&start_sha=67c997f5dcee5c300b14bd1f8db2ddd3c6056f4d)
fhdk commented 2024-07-29 02:57:51 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • d4f6e9ce - Refactor loading logic in Embed class

Compare with previous version

added 1 commit <ul><li>d4f6e9ce - Refactor loading logic in Embed class</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4243&start_sha=045496b33d7db11407a187cb229584492a8e17b6)
fhdk commented 2024-07-29 03:07:11 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 0a52210d - Fix module initialization logic for installed systems

Compare with previous version

added 1 commit <ul><li>0a52210d - Fix module initialization logic for installed systems</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4244&start_sha=d4f6e9ce361d89c52dbda7c75049a11d43f1b279)
fhdk commented 2024-07-29 03:13:45 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 7a968fb3 - Refactor imports

Compare with previous version

added 1 commit <ul><li>7a968fb3 - Refactor imports</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4245&start_sha=0a52210d3730008df578a12effbacde1c32e4e04)
fhdk commented 2024-07-29 03:15:22 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 1e0c157f - Refactor imports

Compare with previous version

added 1 commit <ul><li>1e0c157f - Refactor imports</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4246&start_sha=7a968fb353b5b4578a9ddbe73e492ae53594eb2f)
fhdk commented 2024-07-29 03:23:58 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 2 commits

  • 115b4d74 - Refactor imports
  • b1525011 - Merge remote-tracking branch 'origin/master'

Compare with previous version

added 2 commits <ul><li>115b4d74 - Refactor imports</li><li>b1525011 - Merge remote-tracking branch &#39;origin/master&#39;</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4247&start_sha=1e0c157fc8a03401e5f59e18529fdc3a9a1bc8e1)
fhdk commented 2024-07-29 04:39:17 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 3bbd5316 - Trying to find the cause of

Compare with previous version

added 1 commit <ul><li>3bbd5316 - Trying to find the cause of</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4248&start_sha=b152501101f96457a74a20e80bcca42622a68eaa)
fhdk commented 2024-07-29 04:43:58 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

added 1 commit

  • 5a3203aa - Trying to find the cause of

Compare with previous version

added 1 commit <ul><li>5a3203aa - Trying to find the cause of</li></ul> [Compare with previous version](/applications/manjaro-hello/-/merge_requests/97/diffs?diff_id=4249&start_sha=3bbd531697b199d7a27286c065384af45e8c0938)
fhdk commented 2024-07-29 07:13:11 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

removed review request for @codesardine and @ste74

removed review request for @codesardine and @ste74
fhdk commented 2024-07-29 07:13:33 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

NEEDs more work

NEEDs more work
fhdk (Migrated from gitlab2.manjaro.org) closed this pull request 2024-07-29 07:13:35 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
applications/manjaro-hello!148
No description provided.