Adding to mhwd the version option #87

Merged

philm merged 3 commits from unknown repository into development

2015-03-07 10:30:54 +00:00

philm commented

2015-03-05 16:32:30 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: filipe-marques

Hi!
I add to mhwd the version option, in the menu the options -v or --version, and created the necessary member functions.
I also add a member function to set the version and copyright more easily in main.cpp, that then will
show up, if the user request to show version. With the version and copyright also the user see what is the license.
Added to source files my name and email and also in authors file.
In todo file, could someone explain in more detail, what is to do? Because the list is unconcise.

Thanks!

*Created by: filipe-marques* Hi! I add to mhwd the version option, in the menu the options -v or --version, and created the necessary member functions. I also add a member function to set the version and copyright more easily in main.cpp, that then will show up, if the user request to show version. With the version and copyright also the user see what is the license. Added to source files my name and email and also in authors file. In todo file, could someone explain in more detail, what is to do? Because the list is unconcise. Thanks!

philm commented

2015-03-05 17:46:33 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

So far so good. Can you fix the intentions as they are way of?

*Created by: philmmanjaro* So far so good. Can you fix the intentions as they are way of?

philm commented

2015-03-05 17:47:44 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

TODO is outdated. @december0123, can you update it if needed?

*Created by: philmmanjaro* TODO is outdated. @december0123, can you update it if needed?

philm commented

2015-03-05 19:00:11 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: Kirek

Can you change functions and vars to CamelCase?
For example:
void Mhwd::set_version_mhwd(std::string version_of_software, std::string year_copyright)
to
void Mhwd::setVersionMhwd(std::string versionOfSoftware, std::string yearCopyright)

*Created by: Kirek* Can you change functions and vars to CamelCase? For example: void Mhwd::set_version_mhwd(std::string version_of_software, std::string year_copyright) to void Mhwd::setVersionMhwd(std::string versionOfSoftware, std::string yearCopyright)

philm commented

2015-03-05 19:53:22 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

Right, I forgot about that on my review.

*Created by: philmmanjaro* Right, I forgot about that on my review.

philm commented

2015-03-05 20:19:48 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

Thank you for your contribution. As Kirek stated, please remember to use the style that you see in the code.

*Created by: december0123* Thank you for your contribution. As Kirek stated, please remember to use the style that you see in the code.