applications/mhwd

Fork 0

changes in Mhwd files #89

Merged

philm merged 20 commits from unknown repository into development

2015-06-22 15:24:34 +00:00

philm commented

2015-05-22 09:49:28 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: filipe-marques

changes in Mhwd files, fix tabs for spaces

*Created by: filipe-marques* changes in Mhwd files, fix tabs for spaces

philm commented

2015-05-25 22:33:33 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

seems ok now. @december0123: can you double check this?

*Created by: philmmanjaro* seems ok now. @december0123: can you double check this?

philm commented

2015-06-05 14:05:07 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

I apologize for late response.

*Created by: december0123* I apologize for late response.

philm commented

2015-06-05 14:05:13 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

Dead code. That's good that you removed it.

*Created by: december0123* Dead code. That's good that you removed it.

philm commented

2015-06-05 14:05:16 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

That change just makes the reader confused. You stumble across it and begin to wonder why did someone make that variable static. We don't save memory (found is a bool which is a primitive type - no dynamic memory allocation), we just make the code more confusing and I don't think that's the way to go.

*Created by: december0123* That change just makes the reader confused. You stumble across it and begin to wonder why did someone make that variable static. We don't save memory (found is a bool which is a primitive type - no dynamic memory allocation), we just make the code more confusing and I don't think that's the way to go.

philm commented

2015-06-05 14:05:18 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

Local requirements are checked before this function is called. We don't need that check here.

*Created by: december0123* Local requirements are checked before this function is called. We don't need that check here.

philm commented

2015-06-05 14:05:20 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

Local requirements are checked before this function is called. We don't need that check here.

*Created by: december0123* Local requirements are checked before this function is called. We don't need that check here.

philm commented

2015-06-05 14:05:21 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

That comment should be removed long time ago. You can see that it only confused you (that's why comments should be the last resort and should not be widely used).

*Created by: december0123* That comment should be removed long time ago. You can see that it only confused you (that's why comments should be the last resort and should not be widely used).

philm commented

2015-06-05 14:05:25 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

I think it's fine for now. It's a good idea to finally have a proper readme 👍

*Created by: december0123* I think it's fine for now. It's a good idea to finally have a proper readme :+1:

philm commented

2015-06-05 16:10:43 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: philmmanjaro

I think with these out you can now proper your commit as suggested by @december0123 and he or I will merge your changes ...

*Created by: philmmanjaro* I think with these out you can now proper your commit as suggested by @december0123 and he or I will merge your changes ...

philm commented

2015-06-22 15:24:17 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: december0123

It's ok now. Thanks.

*Created by: december0123* It's ok now. Thanks.