issues with custom mirrorlist #130

New issue

Closed

opened 2018-03-20 23:19:58 +00:00 by oberon · 5 comments

oberon commented

2018-03-20 23:19:58 +00:00

(Migrated from gitlab2.manjaro.org)

I just ran
sudo pacman-mirrors -ic Germany
and selected the three top listed mirrors.

Feedback:

.: INFO User generated mirror list
--------------------------
.: INFO Custom mirror file saved: /var/lib/pacman-mirrors/custom-mirrors.json
.: INFO Writing mirror list
   Germany         : http://mirror.philpot.de/manjaro/unstable/$repo/$arch
   Germany         : http://mirror.philpot.de/manjaro/unstable/$repo/$archunstable/$repo/$arch
.: INFO Mirror list generated and saved to: /etc/pacman.d/mirrorlist

As you can see the http philpot mirror is listed twice, once with a link containing /$archunstable/, which doesn't seem right. The https link is missing, so is the third mirror.
This is also what /etc/pacman.d/mirrorlist actually contains.
Content of /var/lib/pacman-mirrors/custom-mirrors.json:

[
    {
        "country": "Germany",
        "protocols": [
            "https",
            "http"
        ],
        "url": "http://mirror.philpot.de/manjaro/"
    },
    {
        "country": "Germany",
        "protocols": [
            "https",
            "http"
        ],
        "url": "http://mirror.philpot.de/manjaro/"
    },
    {
        "country": "Germany",
        "protocols": [
            "https"
        ],
        "url": "https://repo.rhindon.net/manjaro/"
    }
]

So, the third mirror is listed here, but again philpot http twice, and not the https version.
Another time I had selected two mirrors, ragenet and netzspielplatz and only netzspielplatz got listed. Somehow I cannot reproduce this now, but something seems to not work properly here ...

I just ran `sudo pacman-mirrors -ic Germany` and selected the three top listed mirrors. ![3selected](https://user-images.githubusercontent.com/11800714/37687405-ce6f4700-2c9b-11e8-810a-d2eef08dae2c.png) Feedback: ``` .: INFO User generated mirror list -------------------------- .: INFO Custom mirror file saved: /var/lib/pacman-mirrors/custom-mirrors.json .: INFO Writing mirror list Germany : http://mirror.philpot.de/manjaro/unstable/$repo/$arch Germany : http://mirror.philpot.de/manjaro/unstable/$repo/$archunstable/$repo/$arch .: INFO Mirror list generated and saved to: /etc/pacman.d/mirrorlist ``` As you can see the http philpot mirror is listed twice, once with a link containing `/$archunstable/`, which doesn't seem right. The https link is missing, so is the third mirror. This is also what **/etc/pacman.d/mirrorlist** actually contains. Content of **/var/lib/pacman-mirrors/custom-mirrors.json**: ``` [ { "country": "Germany", "protocols": [ "https", "http" ], "url": "http://mirror.philpot.de/manjaro/" }, { "country": "Germany", "protocols": [ "https", "http" ], "url": "http://mirror.philpot.de/manjaro/" }, { "country": "Germany", "protocols": [ "https" ], "url": "https://repo.rhindon.net/manjaro/" } ] ``` So, the third mirror is listed here, but again philpot http twice, and not the https version. Another time I had selected two mirrors, ragenet and netzspielplatz and only netzspielplatz got listed. Somehow I cannot reproduce this now, but something seems to not work properly here ...

philm commented

2018-03-23 14:26:05 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: fhdk

That is indeed weird

*Created by: fhdk* That is indeed weird

philm commented

2018-03-23 16:43:59 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: fhdk

@oberon2007
That was a nasty one. It has never been in my scenarios that a user would select multiple protocols on the same mirror.

Though it should have - a coder mantra is

"Think like a user" - "A user will double click a button" - "Disable on first click"

But I nailed it - at least I think so.

*Created by: fhdk* @oberon2007 That was a nasty one. It has never been in my scenarios that a user would select multiple protocols on the same mirror. Though it should have - a coder mantra is **"Think like a user" - "A user will double click a button" - "Disable on first click"** But I nailed it - at least I think so.

philm commented

2018-03-23 17:21:32 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: fhdk

Thank you for spotting this.

The condition was indeed not handled properly.

*Created by: fhdk* Thank you for spotting this. The condition was indeed not handled properly.

philm commented

2018-03-25 10:34:17 +00:00

(Migrated from gitlab2.manjaro.org)

Created by: fhdk

https://github.com/manjaro/pacman-mirrors/releases/tag/4.9.1