[Feature Request] Add a --no-color option and/or detect if we are in a terminal #143

New issue

Closed

opened 2018-10-26 10:56:30 +00:00 by guinux · 9 comments

guinux commented

2018-10-26 10:56:30 +00:00

(Migrated from gitlab2.manjaro.org)

It could be useful for pamac to run pacman-mirrors without a colored output.

https://forum.manjaro.org/uploads/default/original/3X/1/f/1fcb9b81b055c5e12c4ddfd133db90eed74b21b3.png

It could be useful for pamac to run pacman-mirrors without a colored output. https://forum.manjaro.org/uploads/default/original/3X/1/f/1fcb9b81b055c5e12c4ddfd133db90eed74b21b3.png

ghost commented

2018-10-26 12:36:28 +00:00

(Migrated from gitlab2.manjaro.org)

I will have a look.

But why would that be useful?

And what if it is run e.g. in Pamac?

I will have a look. But why would that be useful? And what if it is run e.g. in Pamac?

ghost commented

2018-10-26 17:33:34 +00:00

(Migrated from gitlab2.manjaro.org)

@guinux
I have created a pacman-mirrors issue143 branch.

It has been added to unstable as pacman-mirrors-dev ver. 4.12.900.

It takes an argument --no-color which you can use to get the desired output.

I created a wrapper for message printing which takes a flag if colors is printed or not.

Let me know if you can use it.

@guinux I have created a pacman-mirrors **issue143** branch. It has been added to unstable as **pacman-mirrors-dev ver. 4.12.900**. It takes an argument **--no-color** which you can use to get the desired output. I created a wrapper for message printing which takes a flag if colors is printed or not. Let me know if you can use it.

guinux commented

2018-10-27 09:08:19 +00:00

(Migrated from gitlab2.manjaro.org)

Thanks it works !

guinux commented

2018-10-27 09:08:20 +00:00

(Migrated from gitlab2.manjaro.org)

closed

guinux commented

2018-10-27 09:09:53 +00:00

(Migrated from gitlab2.manjaro.org)

Do you know when you will push it to stable ?
This way we can synchronize with the version of pamac using it.

Do you know when you will push it to stable ? This way we can synchronize with the version of pamac using it.

ghost commented

2018-10-27 09:25:58 +00:00

(Migrated from gitlab2.manjaro.org)

I will do some more testing to ensure I have not missed anything or accidently caused any regressions.

ghost commented

2018-10-27 09:27:38 +00:00

(Migrated from gitlab2.manjaro.org)

I have been over the code and done some tidying and added hints and other documentation.

I will push an updated dev package to unstable - so you can test if it still works for Pamac.

I have been over the code and done some tidying and added hints and other documentation. I will push an updated dev package to unstable - so you can test if it still works for Pamac.

ghost commented

2018-10-28 17:04:38 +00:00

(Migrated from gitlab2.manjaro.org)

mentioned in merge request !334