profiles/manjaro-browser-settings
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update master_preferences #8

Closed
philm wants to merge 0 commits from unknown repository into master
pull from: unknown repository
merge into: profiles:master
Conversation 12 Commits - Files changed -
philm commented 2017-11-21 15:59:30 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

Use gtk-theme and system titlebars for better integration with desktops (mainly thinking about bspwm edition, which has chromium as the default browser)

*Created by: Chrysostomus* Use gtk-theme and system titlebars for better integration with desktops (mainly thinking about bspwm edition, which has chromium as the default browser)
philm commented 2017-11-23 14:36:25 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

@oberon2007 , does this make sense in other environments?

*Created by: Chrysostomus* @oberon2007 , does this make sense in other environments?
philm commented 2017-12-04 18:54:41 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

ping @oberon2007

*Created by: Chrysostomus* ping @oberon2007
oberon commented 2017-12-04 23:01:11 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

To be honest I have no idea what this does ... ! 😆

To be honest I have no idea what this does ... ! 😆
philm commented 2017-12-04 23:09:57 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

It

  • makes chromium follow the gtk3 theme by default instead of using the default chromium theme
  • makes chromium use the titlebars and borders of the window manager instead of drawing its own. In case of i3 or bspwm, it means no window buttons and slightly bigger and cleaner window.
*Created by: Chrysostomus* It - makes chromium follow the gtk3 theme by default instead of using the default chromium theme - makes chromium use the titlebars and borders of the window manager instead of drawing its own. In case of i3 or bspwm, it means no window buttons and slightly bigger and cleaner window.
philm commented 2017-12-04 23:10:27 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

I can provide illustration maybe tomorrow

*Created by: Chrysostomus* I can provide illustration maybe tomorrow
philm commented 2017-12-18 21:46:15 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: codesardine

I was about to send a patch for this @Chrysostomus

I also need this for webdad, having matching themes would be nice @oberon2007

https://forum.manjaro.org/t/set-chromium-default-theme-to-gtk/36608

*Created by: codesardine* I was about to send a patch for this @Chrysostomus I also need this for webdad, having matching themes would be nice @oberon2007 https://forum.manjaro.org/t/set-chromium-default-theme-to-gtk/36608
philm commented 2017-12-19 17:21:14 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

Maybe I should make a separate package? It's been a month now without indication of if this is going somewhere, and this is the last issue to solve before releasing the next version of bspwm edition.

*Created by: Chrysostomus* Maybe I should make a separate package? It's been a month now without indication of if this is going somewhere, and this is the last issue to solve before releasing the next version of bspwm edition.
philm commented 2018-01-08 21:33:42 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: codesardine

Any thoughts on this?

*Created by: codesardine* Any thoughts on this?
oberon commented 2018-01-08 21:47:18 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

I'm not all too happy to include this by default since it changes chromium's intended default behaviour.
Maybe a dedicated package for your editions would be a good thing?
@philmmanjaro ?

I'm not all too happy to include this by default since it changes chromium's intended default behaviour. Maybe a dedicated package for your editions would be a good thing? @philmmanjaro ?
philm commented 2018-01-09 01:38:32 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: Chrysostomus

I already did it, manjaro-browser-settings-native. I also figured it was the most reasonable course of action. Btw, the pull request is dysfunctional, but I managed to get it working on the new package.

@codesardine I recommend you use that one instead.

*Created by: Chrysostomus* I already did it, manjaro-browser-settings-native. I also figured it was the most reasonable course of action. Btw, the pull request is dysfunctional, but I managed to get it working on the new package. @codesardine I recommend you use that one instead.
philm commented 2018-01-09 10:53:54 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: codesardine

Ha ok, thanks 👍

*Created by: codesardine* Ha ok, thanks :+1:
philm commented 2018-01-09 19:48:43 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Created by: philmmanjaro

I'd say a NAK from me as well. Same as @oberon2007 already gave. The native package is the way to go here.

*Created by: philmmanjaro* I'd say a NAK from me as well. Same as @oberon2007 already gave. The **native** package is the way to go here.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
profiles/manjaro-browser-settings!8
No description provided.