tools/manjaro-tools
3
0
Fork 0
Code Issues 3 Pull requests Projects Releases 51 Packages Wiki Activity Actions

WIP: Draft: Merge scripts from Arch #672

Closed
yochananmarqos1 wants to merge 0 commits from update-scripts into master
pull from: update-scripts
merge into: tools:master
Conversation 9 Commits - Files changed -
yochananmarqos1 commented 2024-12-13 00:37:16 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Btw, I use devtools. 😉

Btw, I use `devtools`. :wink:
yochananmarqos1 commented 2024-12-13 00:37:16 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

requested review from @oberon and @fhdk

requested review from @oberon and @fhdk
yochananmarqos1 commented 2024-12-13 00:37:16 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

assigned to @philm

assigned to @philm
philm commented 2024-12-13 04:31:23 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Was this actually tested with our tools. Backporting scripts from devtools might need more code changes as those given here.

Was this actually tested with our tools. Backporting scripts from devtools might need more code changes as those given here.
yochananmarqos1 commented 2024-12-13 04:45:44 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

I added two reviewers for a reason. Of course this is something that should not be blindy merged...

I added two reviewers for a reason. Of course this is something that should not be blindy merged...
yochananmarqos1 commented 2024-12-13 05:13:46 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
fhdk commented 2024-12-13 06:11:07 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

This change may introduce unknown factors into manjaro toolbox

This change may introduce unknown factors into manjaro toolbox
fhdk commented 2024-12-13 06:12:20 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

It look like a rewrite to make the code more robust - and appears to have been shellcheck enhanced.

I am not an expert on the toolbox and there is a lot I have never touched or seen and this code is unknown to me - I recall using buildpkg in the past - I also recall that we have somewhat deprecated buildpkg in favor of chrootbuild?

I have never used checkpkg in any context so I am in doubt here

It look like a rewrite to make the code more robust - and appears to have been shellcheck enhanced. I am not an expert on the toolbox and there is a lot I have never touched or seen and this code is unknown to me - I recall using buildpkg in the past - I also recall that we have somewhat deprecated buildpkg in favor of chrootbuild? I have never used checkpkg in any context so I am in doubt here
yochananmarqos1 commented 2024-12-13 19:42:45 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

Good point. Well, I'll just continue using devtools then.

Good point. Well, I'll just continue using `devtools` then.
yochananmarqos1 (Migrated from gitlab2.manjaro.org) closed this pull request 2024-12-13 19:42:48 +00:00
yochananmarqos1 commented 2024-12-13 19:43:56 +00:00 (Migrated from gitlab2.manjaro.org)
Copy link

No one should be using buildpkg, it's unmaintained. We use chrootbuild instead.

No one should be using `buildpkg`, it's unmaintained. We use `chrootbuild` instead.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Done

   
bug

   
buildiso

   
buildpkg

   
buildtree

   
critical

   
deployiso

   
duplicate

   
enhancement

   
help wanted

   
in progress

   
invalid

   
manjaro-chroot

   
note

   
old-not-relevant

   
optional

   
question

   
sonar

   
todo

   
wontfix
No labels
Done
bug
buildiso
buildpkg
buildtree
critical
deployiso
duplicate
enhancement
help wanted
in progress
invalid
manjaro-chroot
note
old-not-relevant
optional
question
sonar
todo
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tools/manjaro-tools!672
No description provided.